Update typecasting.md #4222
Merged
Update typecasting.md #4222
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
IIRC the typecasting matrix was a Google Sheets sheet. I wanted to re-do it in Markdown as three column table (from, to, what type of cast is allowed) but did not get to this so far. Would you be interested in picking this up? |
|
Yeah, can do. Long-format is more in the spirit of SQL too. |
|
Although... are you sure you want a table with 576 entries in the docs? Maybe should that table only include positive entries? That'd be around 100. |
|
Yeah, that sounds reasonable. |
|
@szarnyasg From my perspective this PR is ready to go if you think the contents are right. I'll make a separate PR for the casting matrix when I have time |
|
Sure. I reviewed the text and it's great, merging now. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes duckdb/duckdb#13847 (sadly).
From what I can tell,
BOOL -> INTEGERTYPESis the only example of this special type of casting?Maybe one should get one final confirmation whether it's worth documenting this special type of cast rather than simply dropping it and gaining more PostgreSQL compatibility for it (just to reiterate: I'm all for implicit casts to programatically selected parent types, I just question the value of allowing more implicit casts in this situation than in other implicit cast situations.)
By the way: do you have the HTML for the typecasting matrix? I'd like to resolve #2791 too by adding
INTEGER_LITERAL/STRING_LITERAL/NUMERIC_LITERALto the table (at which point I'd also add the "combination cast" from bool to int to the table)